Toggle the ticker from the banner design preview #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs styling.
We won't be showing the ticker toggle for any cases other than the banner design preview.
tjmw
force-pushed
the
tw/banner-design-preview-toggle-ticker
branch
from
c52ab2a to
4b0f771
Compare
tomrf1
reviewed
Oct 16, 2023
| shouldShowTickerToggle?: boolean; | ||
| } | ||
|
|
||
| const DEFAULT_TICKER_SETTINGS: TickerSettingsWithData = { |
There was a problem hiding this comment.
I wonder if instead of hardcoding this in here we could include tickerSettings in the variant data prop? And let useTickerData do its thing
There was a problem hiding this comment.
I've refactored to support this - most of the complexity around toggling the ticker is now outside of the BannerVariantPreview component. When toggled on for a design the ticker data is threaded through as part of the variant (as usual).
tomrf1
reviewed
Oct 16, 2023
| <BannerVariantPreview | ||
| variant={buildVariantForPreview(design, shouldShowTicker)} | ||
| design={design} | ||
| controls={ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When live previewing a banner design, support toggling the ticker on and off (this setting usually comes from the variant, which is hardcoded in this case).
How to test
Live preview a banner design (locally or in CODE). Toggle the ticker with the control which pops up.
How can we measure success?
Have we considered potential risks?
Images
Accessibility